Page 1 of 1

vba not working

Posted: Thu Mar 16, 2023 1:20 pm
by sna
Hi there

i need your help how to check why my code not working for edit and search vba

Please kindly find the attached

thanks

Re: vba not working

Posted: Thu Mar 16, 2023 1:39 pm
by snasui
:D Please provide all steps for testing, what value in each cell and what button has error and what the result if don't any error. You should post the picture of error for easy for verifying.

Re: vba not working

Posted: Fri Mar 17, 2023 12:03 am
by sna
Hi
It does not show up error.I search by ID if I type 1 it shows the data when click button search and amend data click edit it edit in sheet database but when I type 2 in ID (C5) it doesn't show anything when click search or edit.

Thanks

Re: vba not working

Posted: Fri Mar 17, 2023 5:42 am
by snasui
:D You can adjust that code as below.

Code: Select all

'Other code
For n = 2 To x + 1

    If Sheet2.Range("a" & n) = Sheet1.Range("c5") Then
         Sheet1.Range("c7") = Sheet2.Range("b" & n)
         Sheet1.Range("c9") = Sheet2.Range("c" & n)
         Sheet1.Range("c11") = Sheet2.Range("d" & n)
         Sheet1.Range("f5") = Sheet2.Range("e" & n)
         Sheet1.Range("f7") = Sheet2.Range("f" & n)
         Exit For
    End If

Next n
'Other code

Re: vba not working

Posted: Tue Mar 21, 2023 10:41 am
by sna
thanks but i have another issue for adding new record.it is not working for duplicate adding

Code: Select all

x = Sheet2.Range("a:a").Count
n = Sheet2.Range("a" & x).End(xlUp).Row + 1

For i = 1 To n
    If Sheet2.Range("a" & n) = Sheet2.Range("a" & i) Then
    Sheet2.Range("a" & n & "f:" & n).ClearContents
    MsgBox "ID dup"
    Exit Sub
tks

Re: vba not working

Posted: Tue Mar 21, 2023 11:12 am
by snasui
:D Adjust your code as below.

Code: Select all

'Other code
If Application.CountIfs(Sheet2.Range("a2:a" & n), _
    Sheet1.Range("c5").Value) Then
        MsgBox "ID dup"
    Exit Sub
End If

For i = 1 To n
'    If Sheet2.Range("a" & n) = Sheet2.Range("a" & i) Then
'    Sheet2.Range("a" & n & "f:" & n).ClearContents
'    MsgBox "ID dup"
'    Exit Sub

'Else

    Sheet2.Range("a" & n) = Sheet1.Range("c5")
    Sheet2.Range("b" & n) = Sheet1.Range("c7")
    Sheet2.Range("c" & n) = Sheet1.Range("c9")
    Sheet2.Range("d" & n) = Sheet1.Range("c11")
    Sheet2.Range("e" & n) = Sheet1.Range("f5")
    Sheet2.Range("f" & n) = Sheet1.Range("f7")
'    End If
Next i
'Other code

Re: vba not working

Posted: Wed Mar 22, 2023 1:31 pm
by sna
thanks.it is so helpful